Build net-snmp on macOS 10.14.5 (Mojave)

Wed, 10 Jul 2019 00:00:00 +0000

diff --git a/Makefile.in b/Makefile.in
index 912f6b24d..b32706717 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -18,7 +18,7 @@ INSTALLHEADERS=version.h net-snmp-features.h
 INCLUDESUBDIR=system
 INCLUDESUBDIRHEADERS= aix.h bsd.h bsdi3.h bsdi4.h bsdi.h cygwin.h \
        darwin.h darwin7.h darwin8.h darwin9.h darwin10.h darwin11.h darwin12.h \
-       darwin13.h darwin14.h darwin15.h darwin16.h darwin17.h \
+       darwin13.h darwin14.h darwin15.h darwin16.h darwin17.h darwin18.h \
        dragonfly.h dynix.h \
        freebsd2.h freebsd3.h freebsd4.h freebsd5.h freebsd6.h \
        freebsd7.h freebsd8.h freebsd9.h freebsd10.h freebsd11.h \
diff --git a/include/net-snmp/system/darwin18.h b/include/net-snmp/system/darwin18.h
new file mode 100644
index 000000000..565a09801
--- /dev/null
+++ b/include/net-snmp/system/darwin18.h
@@ -0,0 +1 @@
+#include <net-snmp/system/darwin17.h>

where darwin18 is the version of darwin (uname -r => 18.6.0).

This fixes make error:

making all in /Users/wsh/src/net-snmp/build/agent/mibgroup
/bin/sh ../../libtool  --mode=compile gcc -I../../include -I../../../include -I. -I../../agent -I../../../agent -I../../agent/mibgroup -I../../../agent/mibgroup  -I../../snmplib -I../../../snmplib -D_GNU_SOURCE -D_ALL_SOURCE -D_THREAD_SAFE -D__EXTENSIONS__   -ggdb3 -O0 -DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -DNETSNMP_REMOVE_U64 -ggdb3 -O0 -Udarwin18 -Ddarwin18=darwin18  -Wall -Wextra -Wstrict-prototypes -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -Wno-type-limits -c -o mibII/tcp.lo ../../../agent/mibgroup/mibII/tcp.c
libtool: compile:  gcc -I../../include -I../../../include -I. -I../../agent -I../../../agent -I../../agent/mibgroup -I../../../agent/mibgroup -I../../snmplib -I../../../snmplib -D_GNU_SOURCE -D_ALL_SOURCE -D_THREAD_SAFE -D__EXTENSIONS__ -ggdb3 -O0 -DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -DNETSNMP_REMOVE_U64 -ggdb3 -O0 -Udarwin18 -Ddarwin18=darwin18 -Wall -Wextra -Wstrict-prototypes -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -Wno-type-limits -c ../../../agent/mibgroup/mibII/tcp.c  -fno-common -DPIC -o mibII/.libs/tcp.o
../../../agent/mibgroup/mibII/tcp.c:343:21: error: use of undeclared identifier 'TCPTV_MIN'
        ret_value = TCPTV_MIN / PR_SLOWHZ * 1000;
                    ^
../../../agent/mibgroup/mibII/tcp.c:351:21: error: use of undeclared identifier 'TCPTV_REXMTMAX'
        ret_value = TCPTV_REXMTMAX / PR_SLOWHZ * 1000;
                    ^
2 errors generated.
make[2]: *** [mibII/tcp.lo] Error 1
make[1]: *** [subdirs] Error 1
make: *** [subdirs] Error 1

Process finished with exit code 2

I didn’t send this patch to the upstream because:

it was too expensive for me to understand the way of sending patch to the net-snmp project
the most of the sent patches seem to be neglected

(RETRACTED) Giving invalid parameter to pkill on macOS crashes the parent process

Sun, 17 Dec 2017 00:00:00 +0000

THIS ARTICLE HAS BEEN RETRACTED.

The bug described in this page is of /usr/local/bin/pkill from proctools, not of macOS’s built-in /usr/bin/pkill.

This article is remain unremoved just for web pages which refer this article.

Original Contents

pkill on macOS kills its parent process if a invalid parameter for a option is passed
Verified on OS X 10.11.6 (El Capitan) and macOS 10.12.6 (Sierra)
Seems to be fixed on macOS High Sierra (10.13)

First, let’s look through the usage of pkill:

$ pkill --help
pkill: illegal option -- h
Usage: pkill [-<signal>] [-finvVx] [-g <pgrplist>] [-G <gidlist>] [-P <ppidlist>] [-s <signal>] [-t <termlist>] [-u <euidlist>] [-U <uidlist>] [<pattern>]

Create test-pkill.sh which passes a invalid option -g foo to pkill:

echo 'Executing pkill'
pkill -g foo
echo 'Done'

Execute it.

$ sh test-pkill.sh
Executing pkill
pkill: unable to parse pid: foo
Terminated: 15

$ echo $?
143

Note that Done is not printed; test-pkill.sh was crashed! Terminated: 15 is printed by the shell (here, I used bash) and exit code 143 implies test-pkill.sh is killed with SIGTERM (143 = 128 + 15 = 128 + SIGTERM, see here for details). The message and exit code vary by shell:

$ csh
[wsh5:~/work] wsh% sh test-pkill.sh
Executing pkill
pkill: unable to parse pid: foo
Terminated
[wsh5:~/work] wsh% echo $?
143
[wsh5:~/work] wsh% exit
exit

$ ksh
$ sh test-pkill.sh
Executing pkill
pkill: unable to parse pid: foo
Terminated
$ echo $? # 271 = 256 = 15
271
$ exit

$ zsh
wsh5% sh test-pkill.sh
Executing pkill
pkill: unable to parse pid: foo
zsh: terminated  sh test-pkill.sh
wsh5% echo $?
143
wsh5% exit

$ fish
wsh@wsh5 /U/w/work> sh test-pkill.sh
Executing pkill
pkill: unable to parse pid: foo
fish: Job 1, 'sh test-pkill.sh' terminated by signal SIGTERM (Polite quit request)
wsh@wsh5 /U/w/work> echo $status
143
wsh@wsh5 /U/w/work> exit

I confirmed other options -G, -P, -t, -u, and -U also causes this crash.

This bug was found on Mac OS X 10.11.6 (El Capitan) while investigating a bug in the extension for Visual Studio Code, which crashes Visual Studio Code. This issue argues that the crash occurs on macOS 10.12.6 (Sierra).

Although there’s a room for further investigation (for example, sudo dtruss pkill -P foo reveals that it calls kill(2) to many unrelated processes), I won’t do that since the bug seems to be fixed on macOS 10.12 (High Sierra):

$ sh test-pkill.sh
Executing pkill
usage: pkill [-signal] [-ILfilnovx] [-F pidfile] [-G gid]
             [-P ppid] [-U uid] [-g pgrp]
             [-t tty] [-u euid] pattern
Done

noo-loo-poh exception

Build net-snmp on macOS 10.14.5 (Mojave)

See also

(RETRACTED) Giving invalid parameter to pkill on macOS crashes the parent process

Original Contents